search

makedeb / mprweb

Hosting platform for the makedeb Package Repository (MPR)
https://mpr.makedeb.org
GNU General Public License v2.0
15 stars 3 forks source link

Can't upload a PKGBUILD #98

Open pirate486743186 opened 2 years ago

pirate486743186 commented 2 years ago

Issue

I'm trying to reupload a AUR package. https://aur.archlinux.org/perl-lwp-useragent-cached.git

I kept the git history and it fails with this error.

remote: error: The following error occurred when parsing commit
remote: error: 1acd520f98c9e187a5a31eecd7c7698b3d7c237c:
remote: error: Line 0: Couldn't find ' = ' delimiter.
remote: error: hook declined to update refs/heads/master
To ssh://mpr.makedeb.org/perl-lwp-useragent-cached.git
 ! [remote rejected] master -> master (hook declined)
error: failed to push some refs to 'ssh://mpr.makedeb.org/perl-lwp-useragent-cached.git'
hwittenborn commented 2 years ago

Looking at the commit in that error, it looks like the line in question is a comment in the SRCINFO file, and the MPR's SRCINFO parser doesn't know how to handle such comments. You'll probably need to ditch the Git history and regenerate the SRCINFO file with makedeb, then it should upload fine.

Support for those comments could also be added to the parser, but since this is only an issue with AUR SRCINFO files I'm not quite sure if I want to support it yet.

hwittenborn commented 2 years ago

I needed to rewrite the SRCINFO parsing library for some stuff I was needing the library for, so this comment issue should be fixed in the library itself at least. I'm not sure when I'll get to fixing it in the deployed instance, though I'll try to get that done in the next few days if time allows for it.

pirate486743186 commented 2 years ago

Is it really necessary to check for compliance inside of git history? In this case, i was hopping to preserve the history from AUR. A lot of packages will be ported from AUR.

hwittenborn commented 2 years ago

Is it really necessary to check for compliance inside of git history?

Probably not, but that'd need to be thought about for a bit before I decided if I wanted to not check for such. It's something inherited from aurweb, so I'm sure there's some kind of logic behind it.

Regardless of if it gets changed it definitely won't be immediate since I'm busy with other makedeb stuff, an immediate solution would definitely just be to ditch the commit history, otherwise you'll probably be stuck waiting for a bit.