makehackvoid / makehackvoid.com

MHV public facing website
MIT License
9 stars 10 forks source link

Add Google Plus social icon #105

Open brendam opened 9 years ago

brendam commented 9 years ago

I tried to add a Google Plus social icon (need link to our G+ page to show Google we 'own' the website). The icon is added by updating two files:

_config.yml

-  gplus:        '404'
+  gplus:        '113375093826168243563'

and

_includes/_blog-cover.html

{% if site.inc.gplus %}
<a href="https://plus.google.com/{{ site.inc.gplus }}" rel="publisher" target="_blank"><i class="icon icon-google-plus"></i></a>
 {% endif %}

But the icon doesn't show. We seem to have our icons base64 encoded in _assets/stylesheets/_icons.scss - does anyone know how this was done, and why? Need to add the icon-google-plus fontawesome icon.

Once the icon is working, we can remove the Google+ link at the bottom of the page (and the dot before it) in _layouts/base.html:

<a href="/code-of-conduct" class="home">Code of Conduct</a> &middot;
<a href="https://plus.google.com/112979231363915834801" rel="publisher">Google+</a>
brendam commented 9 years ago

updated which G+ page is being pointed to - needed to be the one with our videos linked to it. https://plus.google.com/113375093826168243563

jamiereid commented 8 years ago

Found this: https://github.com/odyniec/font-awesome-to-png Having trouble with python (like always :P); will try again tomorrow - reached my jamie-angry-at-python level for tonight.

klepas commented 8 years ago

Shortcode is fa-google-plus, no?

<i class="icon fa-google-plus"></i></a>

[Cheatsheet]

jamiereid commented 8 years ago

The problem is @klepas that we aren't importing the full Font Awesome anywhere (that I could find..). Currently any icons we are using are stored as base64 encoded pngs in the _icons.scss file.

jamiereid commented 8 years ago

Solved with the font-awesome-to-png script. Thanks @devdsp for the help too!

klepas commented 8 years ago

I didn’t get back to this. Good fix.

FWIW, my recent technique for pulling in all the icons in another project has been to use the font-awesome SASS gem (font-awesome-sass).