search

makehackvoid / makehackvoid.com

MHV public facing website
MIT License
9 stars 10 forks source link

Change all urls to use current method of access. Closes #118 #121

Closed jamiereid closed 8 years ago

jamiereid commented 8 years ago

This is forced to https for our local site.

jamiereid commented 8 years ago

This should be fine (tested locally using http and works ok - can't test https until we push to live server?)

cmrn commented 8 years ago

I would suggest explicitly using HTTPS for all URLs that support it, to make sure that HTTPS is used whenever possible (even when the website is run in HTTP mode).

I think that this PR also breaks some links that do not support HTTPS, when makehackvoid.com is accessed using HTTPS. For example, //ultrakeet.com.au in projects/_posts/2012-03-16-pc-to-pcb.md does not support HTTPS, so this link would be broken when that post is loaded with HTTPS.

jamiereid commented 8 years ago

No worries, I'll change this PR when I get a chance (hopefully tonight/tomorrow night).

My thought process behind not explicitly using https was simply that we force a redirect on http://makehackvoid.com - but I think your way is better.

cmrn commented 8 years ago

Yeah I understand your logic there. I'd suggest a mixed approach - use the // syntax for makehackvoid.com URLs, but for external URLs use HTTPS if available, otherwise use HTTP.

jamiereid commented 8 years ago

New commit making the changes we discussed :)

cmrn commented 8 years ago

Thanks for doing this @jamiereid - must've been a tedious job checking each domain! :+1: