search

makehackvoid / makehackvoid.com

MHV public facing website
MIT License
9 stars 10 forks source link

Suggestion - Create dark theme #60

Closed mbainrot closed 10 years ago

mbainrot commented 10 years ago

If possible (I haven't had a good look at the code yet) could we have a dark theme?

Main reason being is being able to keep both screens a consistent brightness, to avoid the "ahhhh the light" syndrome when you change tabs.

Not overly high priority but a nice to have none the less

cmrn commented 10 years ago

I don't really like this idea - it requires setting a cookie on the client to store the setting, a fair amount of work making sure any style changes work in both things, and I can't see many people using the feature.

Additionally, the vast majority of websites use a white background, so I don't see how the "ahhhh the light" issue is particularly related to makehackvoid.com, if you have chosen to set your computer up as you suggest.

Others may see it differently, but I'm inclined to close this suggestion.

B0073D commented 10 years ago

Whilst I am a fan of dark themes, I have to agree with Cameron. Additionally, there are plugins available for most browsers that will help with the light issue.

On Tue, Jan 28, 2014 at 1:43 PM, Cameron Moon notifications@github.comwrote:

I don't really like this idea - it requires setting a cookie on the client to store the setting, a fair amount of work making sure any style changes work in both things, and I can't see many people using the feature.

Additionally, the vast majority of websites use a white background, so I don't see how the "ahhhh the light" issue is particularly related to makehackvoid.com, if you have chosen to set your computer up as you suggest.

Others may see it differently, but I'm inclined to close this suggestion.

— Reply to this email directly or view it on GitHubhttps://github.com/makehackvoid/makehackvoid.com/issues/60#issuecomment-33446566 .

Sincerely,

Tim Suess

Alternative Thought

www.B0073D.com

mbainrot commented 10 years ago

That is a fairly valid point, I am not 100% sure how the website works yet (running up a virtual machine right now) so wasn't sure if it was a pain.

brendam commented 10 years ago

we are trying to keep the site simple, would prefer not to have optional themes at this stage.