Closed mbainrot closed 6 years ago
Sorry to be so slow on responding to this @mbainrot. I think this will fail to match if the persons email has been stored as uppercase or mixed case? Need to update the exists function in members.py to do lowercase matching or else update the 'save' function in members.py to store in lowercase (and the convert the existing records in the database - I've checked, and there are uppercase letters in email field).
Okies I'll have a look at it with fresh eyes tonight On 28 May 2015 4:22 pm, "Brenda Moon" notifications@github.com wrote:
Sorry to be so slow on responding to this @mbainrot https://github.com/mbainrot. I think this will fail to match if the persons email has been stored as uppercase or mixed case? Need to update the exists function in members.py to do lowercase matching or else update the 'save' function in members.py to store in lowercase (and the convert the existing records in the database - I've checked, and there are uppercase letters in email field).
— Reply to this email directly or view it on GitHub https://github.com/makehackvoid/mhvdb2/pull/104#issuecomment-106193534.
Implemented changes as requested @brendam but added some extra things to fix an issue whereby SSL verification fails. Also optimised the apt-get pulls because the builds where painfully slow.
there is some regressions so will close this PR and open a new one once I work it all out.
Quick and dirty fix, instead of me whinging via an issue figured I'd just fix and pull request :P
Added .lower() to negate overly helpful-cellphones capitalising emails which results in it complaining that your email doesn't exist despite mhvdb emailing you in the first place :)
Took me a bit to remember how to pull request hehehe