Closed mbainrot closed 4 years ago
Hi Max. Thanks for the PR! I wanted to acknowledge it, and say that I havn't had time to review, but will make some time on the weekend unless someone beats me to it. -J
Thanks Jamie!
The main thing I need cross checked is it's ""live"" functionality as I did manage to break the build in one of my iterations leading up to my PR without Jenkins failing the build. I think this happened because either Jenkins doesn't test all of the possible points or because it doesn't test it live. I did some testing myself but I don't trust my tired eyes so I'd very much appreciate a peer review to make sure I am not a muppet š
p/s when I say live I mean like with the consortium of services running together, not production, I may be crazy but I ain't that crazy š
/usr/lib/ssl/certs/bundle.CA_BUNDLE
and settingverify='/usr/lib/ssl/certs/bundle.CA_BUNDLE'
in therequests.post()
function in mailer.pyAppologies to everyone for all the email spam (if any) while I learneded to git again š
p/s ping @jamiereid