search

makehumancommunity / makehuman

This is the main repository for the MakeHuman application as such.
http://www.makehumancommunity.org
Other
1.18k stars 244 forks source link

Incorrect Knee Joint position with Height slider towards short #159

Closed Hunanbean closed 2 years ago

Hunanbean commented 3 years ago

If you move the height slider left, towards short, the knee joint position gets severely out of place. The shorter the character, the more the knee joint is in the thigh. It is far enough out of place to make short humanoids unusable.

http://www.makehumancommunity.org/forum/viewtopic.php?f=3&t=19379

Thank you

black-punkduck commented 3 years ago

okay, it took me a while to understand that we have a bigger problem here.

All shapekey/target files in data/targets/macrodetails/height have the same problem. The cubes for the knee position of the bones are moving independently from the loopcuts of the skin mesh. Unfortunately these are a huge number of wrong targets now and I don't know if they had been generated somewhen. In case they are not generated, I have to do them one by one. I can do that in the branch I already created (the one with the symmetry issue).

If there is no other way, it is boring and it will take a while. I did a "md5sum * | sort" (see .txt file) on the folder to see, which files are equal to have less work, but it is still a bunch of them. Don't ask me why we save 20 times the same file and don't have a json file containing (partly the same) names for the specific target, since all the other modifiers are applied using a json configuration file. If you check which of the files are different ... at least I did not find a reason other than some have been tweaked later. I am pretty sure this is history and happened long before I joined the team ;)

if you have another idea, please let me know. Otherwise I will start with the task soon in the way I described.

files_to_change.txt

black-punkduck commented 3 years ago

I will ask for a merge request ... I did all the changes. Not manually of course but also not fully automatic :)

Hunanbean commented 3 years ago

You rock! :)

On Mon, Apr 19, 2021 at 2:52 PM black-punkduck @.***> wrote:

I will ask for a merge request ... I did all the changes. Not manually of course but also not fully automatic :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/makehumancommunity/makehuman/issues/159#issuecomment-822810478, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNVR7EARIR6WLVUOIUMOSLTJSQY5ANCNFSM422ZPBZQ .

joepal1976 commented 3 years ago

Probably fixed in https://github.com/makehumancommunity/makehuman/pull/160, but will need some testing before we close this issue.

Hunanbean commented 2 years ago

So far all of my test have shown it fixed, but i do not know what internal testing you may do.