makehumancommunity / makehuman

This is the main repository for the MakeHuman application as such.
http://www.makehumancommunity.org
Other
1.18k stars 244 forks source link

Fix compile_targets.py when using numpy 1.24.0 or newer #220

Closed pekkarr closed 1 year ago

pekkarr commented 1 year ago

Fixes #217

Numpy 1.24.0 removed creation of arrays with mismatched dimensions to have implicit dtype=object. To maintain the old behavior, dtype=object has to be specified explicitly.

https://numpy.org/neps/nep-0034-infer-dtype-is-object.html

This changes the return type of LicenseInfo.toNumpyString() to a numpy array. The method is used in three places:

joepal1976 commented 1 year ago

So far validated not causing problems on earlier numpy (1.17.4)

joepal1976 commented 1 year ago

Can't see any obvious downside of this. Going to merge so it ends up in nightly and see if we feedback from somewhere else.