makehumancommunity / mpfb2

MPFB2 is a free and open source human generator for Blender
http://static.makehumancommunity.org/mpfb.html
Other
262 stars 31 forks source link

head-scale-vert is incorrectly loaded as forehead-scale-vert #139

Closed skunkbear closed 8 months ago

skunkbear commented 9 months ago

Describe the bug When loading a preset, the value of head-scale-vert-decr-incr on the blender object is not set, and the value of head-scale-vert-incr/head-scale-vert-decr is instead applied to forehead-head-scale-vert-incr-decr. Effectively, this causes the preset to load with the vertical scale of just its forehead changed, instead of that of the whole head.

Platform and versions

skunkbear commented 9 months ago

(Edited: At first I thought it saved incorrectly, but it actually seems to save correctly but load the .json incorrectly.)

joepal1976 commented 9 months ago

Ok, I think I see a scenario where this might happen. Would you mind sharing the json file here? It can be found by clicking "system and resources" -> "directories" -> "user files" -> "config" and will be named "human.[name of the character].json".

skunkbear commented 9 months ago

human.Loot.zip This json contains the entry { "target": "head-scale-vert-incr", "value": 0.5 } but when I use it to create a new human from preset, its forehead vert scale is set instead of the whole head.

joepal1976 commented 8 months ago

@skunkbear I've pushed a fix which I think solves this problem. Can you check if your file is deserialized correctly now? The fix is in git now and will be in the nightly build tomorrow.

skunkbear commented 8 months ago

Yep, it seems to work correctly now. Thank you!

joepal1976 commented 8 months ago

Assuming this works.