search

makenai / robotnik

Drag and drop robotics educational library starring Johnny Five and Blockly (crowd goes wild)
52 stars 13 forks source link

Replace Ace with CodeMirror #23

Closed lynnaloo closed 9 years ago

lynnaloo commented 9 years ago

Removing the Ace library from static and adding the CodeMirror npm module to robotnik.js

lynnaloo commented 9 years ago

I'm going to merge with #22 before I do a PR for this

Resseguie commented 9 years ago

Just for completeness sake, can we document here the reasoning for switching editors? (I don't have much experience with either, so this is partly because I'm curious to learn the pros/cons.)

lynnaloo commented 9 years ago

@makenai Did you have any specific preference for one over the other? There is an npm package for CodeMirror which is nice. Googling is showing points in favor of both so I don't know that there's a clear winner.

This is an interesting thread: https://github.com/adobe/brackets/issues/1142

BrianGenisio commented 9 years ago

I have a lot of experience with CodeMirror... I use it in my dayjob project. It is solid. I don't know anything about Ace, but from my understanding, it is equally solid.

Resseguie commented 9 years ago

CodeMirror was used by j5-chrome for the original Chromebots too.

monteslu commented 9 years ago

Don't remember why we switched on chromebots, but I'm really liking codemirror