makenai / sumobot-jr

Sumobot Jr. is an open source sumo design for Nodebots Day sumo competitions and similar
150 stars 82 forks source link

Mounting hole options #16

Open dtex opened 8 years ago

dtex commented 8 years ago

I'd like to add a parameter to the SCAD file for choosing different hole patterns for the top plate (Tessel 2 is my use case). Does that sound like a worthwhile PR?

makenai commented 8 years ago

Yup - most certainly. Thanks for looking at the SCAD files instead of the vectors. :)

I think you should be able to add an parameter / method to it similar to the arduino and pinoccio ones here: https://github.com/makenai/sumobot-jr/blob/master/3d_print/sumobot.scad#L186

dtex commented 8 years ago

Cool. I was thinking of adding a parameter like this:

// Mounting hole pattern
// valid values are "Arduino Uno", "Tessel 2"
hole_pattern = "Arduino Uno";

And then just add a conditional in top to call the right module.

dtex commented 8 years ago

Hmmm, like most things it's never as easy as it seems. I had to make the sled wider to fit the mounting holes, but the GPIO ports are still kind of exposed (anything plugged in could be easily ripped out by another sumo).

Sigh...

I'll keep playing with it.

Sumobot with Tessel 2

dtex commented 8 years ago

I'm thinking it makes the most sense to have an option for Tessel mounting holes like we discussed, but then just have a note somewhere (the readme?) that gives the minimum sled width and a suggested sled length... Well, maybe not. I don't see any reason we couldn't set the default width and height based on that same hole_pattern variable.