search

makenotion / notion-sdk-js

Official Notion JavaScript Client
https://developers.notion.com/docs
MIT License
4.96k stars 592 forks source link

fix: add missing `request_id` type to `OauthTokenResponse` #481

Closed MohammedEsafi closed 10 months ago

MohammedEsafi commented 11 months ago

This pull request addresses the addition of a missing request_id type in the OauthTokenResponse TypeScript definition

Changes Made

Added TypeScript type definition for request_id in the OauthTokenResponse

Example Oauth Response

{
  "access_token": ...,
  "token_type": ...,
  "bot_id": ...,
  "workspace_name": "Mohammed Esafi",
  "workspace_icon": null,
  "workspace_id": ...,
  "owner": ...,
  "duplicated_template_id": ...,
  "request_id": "ae17caab-bad9-424f-98c7-e00daa2a1317"
}
CLAassistant commented 11 months ago

CLA assistant check
All committers have signed the CLA.

cwang314 commented 10 months ago

Hey, thanks for opening this PR. We're doing some git history cleanup and need to close the PR as it'll become invalid. Afterwards, please reclone the repo and you can reopen the PR. Thanks for your patience and sincere apologies for the trouble.