makeomatic / redux-connect

Provides decorator for resolving async props in react-router, extremely useful for handling server-side rendering in React
MIT License
549 stars 66 forks source link

DeprecationWarning: Unhandled promise rejections are deprecated. #103

Open Mikeysax opened 7 years ago

Mikeysax commented 7 years ago

Everything is working pretty well but when I refresh on 1 Container out of 5 that are using redux-connect, I get this:

(node:27184) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Then I realize, the documentation is missing catch for loadOnServer method. I think the Readme needs to be updated.

Example:

loadOnServer({...renderProps, store}).then(() => {
        const components = renderToStaticMarkup(
          <Provider store={store}>
             <ReduxAsyncConnect {...renderProps} />
          </Provider>
        );
        res.status(200);
        res.send('<!doctype html>\n' +
          renderToString(
            <InitialPage
              assets={webpackIsomorphicTools.assets()}
              component={components}
              store={store}
            />
          )
        );
      })
      .catch(err => {
        console.log('Caught Error in Server Render: ');
        console.log(err);
      });
AVVS commented 7 years ago

Sure, please send a PR!