Mobile no longer has a pathing queue
Enemy and NPC will now only have pathing queue
Move method is now in Entity
-added functionality of actually moving the item in the Tile array lists
-Entities also are added into the Tile’s array list upon instantiation
(I dont like the way ive done move… we need to decide if Position or entity should handle it)
Tile(and subs)
Removed any constructor that doesn’t require a position
Types of changes
What types of changes does your code introduce?
Put an x in the boxes that apply
[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. This is simply a reminder of what we are going to look for before merging your code.
[ ] My changeset covers only what is described above (no extraneous changes)
[ ] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged downstream
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...
russella26
commented
2 years ago
Proposed changes
Move method is now in Entity -added functionality of actually moving the item in the Tile array lists -Entities also are added into the Tile’s array list upon instantiation
(I dont like the way ive done move… we need to decide if Position or entity should handle it)
Tile(and subs)
Types of changes
What types of changes does your code introduce? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...