makeopensource / Classic-RPG

A classic role-playing game with an engine.
GNU General Public License v3.0
7 stars 19 forks source link

add_connection instead of add_oneway_connection #78

Closed zacharyLYH closed 1 year ago

zacharyLYH commented 1 year ago

Proposed changes

Change add_oneway_connection method call to add_connection. The former is not implemented, the latter is an equivalent.

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

Checklist

Put an `` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...x

emilkovacev commented 1 year ago

Apologies for the late response! Were you able to verify that "game-1.py" runs properly?

zacharyLYH commented 1 year ago

Yes. Making those changes and then running python3 game-1.py allowed me to play the game.

emilkovacev commented 1 year ago

Really sorry about this, I noticed that your PR introduced the pycache directory. Can you make another PR with this change, but removing pycache ?