search

makeopensource / Classic-RPG

A classic role-playing game with an engine.
GNU General Public License v3.0
7 stars 19 forks source link

Game audio #81

Closed Upside-Sandwich closed 1 year ago

Upside-Sandwich commented 1 year ago

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

Checklist

Put an `` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...x

emilkovacev commented 1 year ago

Only one requested change – can you change the naming convention of the files from camelCase to snake_case?

emilkovacev commented 1 year ago

Additionally (while not required) I think it would be cool if you maintained a README.md file in the rpgAudio directory, detailing what you intend each sound to be for!

Upside-Sandwich commented 1 year ago

I will get on that once I figure out how to update my file on Git.

On Mon, Sep 19, 2022 at 3:14 PM Emil Kovacev @.***> wrote:

Additionally (while not required) I think it would be cool if you maintained a README.md file in the rpgAudio directory, detailing what you intend each sound to be for!

— Reply to this email directly, view it on GitHub https://github.com/makeopensource/Classic-RPG/pull/81#issuecomment-1251436962, or unsubscribe https://github.com/notifications/unsubscribe-auth/A227ZJTP4WZSIZJ5VF4DMZDV7C3QZANCNFSM6AAAAAAQN2ULL4 . You are receiving this because you authored the thread.Message ID: @.***>

WeirdAlex03 commented 1 year ago

I don't believe it's possible to rename them on GitHub, if that's what you mean. But if you have the repo on your computer, you can just rename them as normal and commit/push to your fork. Then you'll see the commit in the timeline here

I do have questions about naming though. Namely, why are all the file names prefixed with an a? Also, I think it might be better just to call the folder audio. Then we can use the same folder for any other sounds we might want (and these current ones can be moved to audio/rpg/ if need be)

Upside-Sandwich commented 1 year ago

The naming conventions are purely for my own organization while the files are on my computer. I can make them normal.

On Thu, Sep 22, 2022 at 1:49 PM Alex M @.***> wrote:

I don't believe it's possible to rename them on GitHub, if that's what you mean. But if you have the repo on your computer, you can just rename them as normal and commit/push to your fork. Then you'll see the commit in the timeline here

I do have questions about naming though. Namely, why are all the file names prefixed with an a? Also, I think it might be better just to call the folder audio. Then we can use the same folder for any other sounds we might want (and these current ones can be moved to audio/rpg/ if need be)

— Reply to this email directly, view it on GitHub https://github.com/makeopensource/Classic-RPG/pull/81#issuecomment-1255358161, or unsubscribe https://github.com/notifications/unsubscribe-auth/A227ZJQFFBQIDE3B2FHZEZ3V7SLZ3ANCNFSM6AAAAAAQN2ULL4 . You are receiving this because you authored the thread.Message ID: @.***>

Upside-Sandwich commented 1 year ago

I'll be real, that took me way too long to do. Sorry.