search

makepanic / ember-power-calendar-date-fns

Internal utils of Ember Power Calendar built on top of date-fns
MIT License
2 stars 8 forks source link

feat: allow user to exclude date-fns locales #11

Closed makepanic closed 4 years ago

makepanic commented 4 years ago

fixes #10

makepanic commented 4 years ago

Seems to work pretty ok:

includeLocales: false:

 - dist/assets/auto-import-fastboot-d41d8cd98f00b204e9800998ecf8427e.js: 0 B
 - dist/assets/dummy-24d7944e15f99e05678d9e09d0203a31.js: 8.58 KB (1.57 KB gzipped)
 - dist/assets/dummy-b06e59e1e6434f2b63545acf31a714e4.css: 4.02 KB (779 B gzipped)
 - dist/assets/vendor-363b24984561140a5702529d7e4d5c16.js: 617.91 KB (153.07 KB gzipped)
 - dist/assets/vendor-d41d8cd98f00b204e9800998ecf8427e.css: 0 B

includeLocales: false/ default:

 - dist/assets/auto-import-fastboot-d41d8cd98f00b204e9800998ecf8427e.js: 0 B
 - dist/assets/dummy-24d7944e15f99e05678d9e09d0203a31.js: 8.58 KB (1.57 KB gzipped)
 - dist/assets/dummy-b06e59e1e6434f2b63545acf31a714e4.css: 4.02 KB (779 B gzipped)
 - dist/assets/vendor-2b7acada006de9e5e0c3133ec98debf7.js: 977.56 KB (216.12 KB gzipped)
 - dist/assets/vendor-d41d8cd98f00b204e9800998ecf8427e.css: 0 B
makepanic commented 4 years ago

@veelci when localizing the calendar, do you want to have all possible translations available or would it be ok to provide a list of locales that will be included from date-fns/locales/*?

e.g. ['de', 'fr', 'it', 'en']

It seems like a full locale build bundles ~360 KB more JS.

makepanic commented 4 years ago

Nvm it was super easy to also allow a list of locales, so the developer can configure which date-fns locales to include, see https://github.com/makepanic/ember-power-calendar-date-fns/blob/e83361c6e403951b1282f2e3f6e41b9a52d855df/README.md#using-date-fnslocale

makepanic commented 4 years ago

released as 0.3.1

veelci commented 4 years ago

Thank you.