makepanic / ember-power-calendar-date-fns

Internal utils of Ember Power Calendar built on top of date-fns
MIT License
2 stars 8 forks source link

Error when specifying 'en' in the list of included locales. #15

Closed veelci closed 11 months ago

veelci commented 4 years ago

When specifying 'en' in the list of included locales, I'm getting an error:

Can't resolve 'date-fns/locale/en'

I believe this is because 'en' is used as the default locale for date-fns. It isn't in the docs for ^2.0.0, but can be found in the Supported Languages section of the Internationalization docs for v1.30.1.

date-fns currently supports:

  • English (en; it's the built-in language and doesn't require any setup)

Possible solutions:

makepanic commented 4 years ago

Oops sorry. It seems like you're right. They don't have a simple en definition in their locales.

I'll adjust the README

makepanic commented 4 years ago

I've updated the README. It seems like the default locale is en-US so you'd have to also specify that (en-US) in the list of locales, if you only want to include that.

veelci commented 11 months ago

Thank you.