search

makepanic / ember-power-calendar-date-fns

Internal utils of Ember Power Calendar built on top of date-fns
MIT License
2 stars 8 forks source link

fix: normalize known power-calendar format strings to date-fns v2 #18

Closed makepanic closed 4 years ago

makepanic commented 4 years ago

fixes #17

makepanic commented 4 years ago

@veelci if you have a moment, can you review this? See https://github.com/makepanic/ember-power-calendar-date-fns/issues/17 for the base issue.

There's still the issue that a developer might want to use a format that's also used by power-calendar, e.g. YYYY-MM-DD where it wants to display the day of the year (0-365). This will be converted as we have no way to decide what the developers intention is.

veelci commented 4 years ago

Your changes look good. I would think displaying the day of year in the calendar would be a rarer case.