search

makepanic / ember-power-calendar-date-fns

Internal utils of Ember Power Calendar built on top of date-fns
MIT License
2 stars 8 forks source link

Embroider compatibility #42

Open dbendaou opened 2 years ago

dbendaou commented 2 years ago

It seems that the addon cannot be run with Embroider. Indeed, I have the following error in my test

Screenshot 2021-10-07 at 17 48 05

I would say that it's caused by the fact that we're renaming the import path of the addon from ember-power-calendar-date-fns to ember-power-calendar-util but I'm not sure how we could fix that

Techn1x commented 1 year ago

I think a great first step to upgrading this plugin would be to use the moment & luxon plugins as a guide, which are much more up to date (eg ember-auto-import v2), and also seem way simpler (eg only exporting a single index.js and using broccoli-funnel to move to xxx-utils, no use of string-replace) https://github.com/cibernox/ember-power-calendar-moment https://github.com/cibernox/ember-power-calendar-luxon

cc @cibernox

Techn1x commented 1 year ago

cc @makepanic if you're still around