search

makepanic / ember-power-calendar-date-fns

Internal utils of Ember Power Calendar built on top of date-fns
MIT License
2 stars 8 forks source link

Update to ember v4.12 & use latest `ember-power-calendar` version #54

Open mkszepp opened 1 year ago

mkszepp commented 1 year ago

fix #53 & fix #42

related issue

Techn1x commented 1 year ago

cc @makepanic

mkszepp commented 9 months ago

@makepanic friendly ping... ember-power-calendar is now released

Techn1x commented 9 months ago

They are still slightly active on github so hopefully we don't need to resort to a fork..

Techn1x commented 9 months ago

I tried registering this plugin (from main branch) with ember-power-calendar 0.21.0, it kinda worked when I imported from the incorrect name 'ember-power-calendar-utils' but it had issues in my embroider application. I then tried the same with this PR (but importing from the correct namespace), but I had trouble forking this addon and installing this PR as an addon.

So I've just copied the unlocalized.js and format-util.js files into my application (I was using with includeLocales: false, so didn't need localized.js) and then register the unlocalized file as my plugin

import { registerDateLibrary } from "ember-power-calendar";
import * as DateUtils from "my-app/utils/ember-power-calendar-date-fns/unlocalized";
registerDateLibrary(DateUtils);

I'll keep an eye on this PR if the maintainer ever comes back to merge & release it but I appreciate the work you did here. Others will probably find it useful too.

mkszepp commented 5 months ago

@makepanic can we get a release with this changes, otherwise we get a lot of noises on our ember-power-calendar package, that this meta packages is outdated...

If you don't have time to maintain, it would be good to get permissions to merge changes / deploy them.

As alternative we have planned to bring this addon earlier / later directly to our core addon

veelci commented 5 months ago

@makepanic Can you please review this PR? I'm starting to run into this as well.

krisswiltshire30 commented 3 months ago

@makepanic can you please review this PR?

As @mkszepp said, if you are unable to maintain at this time can you delegate maintenance to someone else?

mkszepp commented 3 months ago

I think there is no other way as making a fork for that and release that...

I will try to find time in next days. For now you can use my fork.

When i have done i will notify here everyone