search

makepath / xarray-spatial

Raster-based Spatial Analytics for Python
https://xarray-spatial.readthedocs.io/
MIT License
825 stars 84 forks source link

Test Viewshed Analysis against other Viewshed Implementations #669

Open yiftachn opened 2 years ago

yiftachn commented 2 years ago

Has anyone tested the correctness of the viewshed analysis output? Assuming ESRI's ArcGIS as the ground truth, as it is the most popular, paid, solid and established viewshed product, Does xarray-spatial viewshed returns identical output?

ianthomas23 commented 2 years ago

Personally I don't trust any mathematical software unless I can verify that the maths is implemented correctly.

It you want to compare the two, feel free to do so and report your results here if you wish.

brendancol commented 2 years ago

@yiftachn We may have a test to check against GDAL's viewshed which was the inspiration for this tool. @davidnfox I think we should also test against Esri just to know how different the two are.

yiftachn commented 2 years ago

Great, im following

On Sat, Apr 30, 2022, 02:43 Brendan Collins @.***> wrote:

@yiftachn https://github.com/yiftachn We may have a test to check against GDAL's viewshed which was the inspiration for this tool. @davidnfox https://github.com/davidnfox I think we should also test against Esri just to know how different the two are.

— Reply to this email directly, view it on GitHub https://github.com/makepath/xarray-spatial/issues/669#issuecomment-1113863656, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJCIP3TE2VYUVQ2YKR6RL7LVHRXZZANCNFSM5PCBXBBA . You are receiving this because you were mentioned.Message ID: @.***>