search

makepath / xarray-spatial

Raster-based Spatial Analytics for Python
https://xarray-spatial.readthedocs.io/
MIT License
828 stars 84 forks source link

Drop CuPy support for natural_breaks #704

Closed thuydotm closed 2 years ago

thuydotm commented 2 years ago

This current implementation of natural_breaks algorithm is extremely sequential. The GPU support for this function does not improve but worsen the performance as there is no paralelizable part. It just changes the numpy buffers with cupy buffers without using numba. For these reasons, we should completely remove it.

codecov-commenter commented 2 years ago

Codecov Report

Merging #704 (1f1bb88) into master (9a5cf1e) will increase coverage by 0.59%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #704      +/-   ##
==========================================
+ Coverage   80.61%   81.21%   +0.59%     
==========================================
  Files          19       19              
  Lines        4111     4077      -34     
==========================================
- Hits         3314     3311       -3     
+ Misses        797      766      -31
Impacted Files Coverage Δ
xrspatial/curvature.py 72.88% <ø> (ø)
xrspatial/focal.py 67.88% <ø> (ø)
xrspatial/proximity.py 96.78% <ø> (ø)
xrspatial/viewshed.py 88.88% <ø> (ø)
xrspatial/zonal.py 85.44% <ø> (ø)
xrspatial/classify.py 78.03% <100.00%> (+7.89%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9a5cf1e...1f1bb88. Read the comment docs.