search

makeplane / plane

🔥 🔥 🔥 Open Source JIRA, Linear and Asana Alternative. Plane helps you track your issues, epics, and product roadmaps in the simplest way possible.
http://plane.so
GNU Affero General Public License v3.0
26.11k stars 1.41k forks source link

[bug]: Update to Docker command breaks production installs #4646

Open Fmstrat opened 1 month ago

Fmstrat commented 1 month ago

Is there an existing issue for this?

Current behavior

Recently the stable docker images changed their command structure. For instance, command: /usr/local/bin/start.sh web/server.js web was changed to command: node web/server.js web in the compose files.

This is a breaking change for any user hosting via docker. command shouldn't be an option used in compose unless you are trying to alter the intended function. stable images should use CMD in the Dockerfile, and command should be removed from the compose files to ensure future iterations of images use the appropriate startup.

If the plane-backend wishes to be reused for low-size, a base plane-backend image should be built, and a plane-api image should be built FROM plane-backend to allow for separate CMD use.

Steps to reproduce

  1. Docker pull the latest stable from an install prior to this commit: https://github.com/makeplane/plane/commit/1c377163d2b184fae5806ee33ef0325d79e51ade
  2. Restart
  3. Watch production go down

Environment

Production

Browser

None

Variant

Self-hosted

Version

stable

mguptahub commented 1 month ago

@Fmstrat

I agree with what you said about the CMD must be at docker image level. We have noted it and will fix it in upcoming releases.