search

makerbase-mks / MKS-Robin-E3-E3D

MKS Robin E3 E3D 32Bit Control Board 3D Printer parts with tmc2209 Uart mode driver For Creality Ender 3 CR-10
https://www.aliexpress.com/item/4000781744682.html
GNU General Public License v3.0
118 stars 97 forks source link

Incorrect serial port -1 #61

Closed ellensp closed 3 years ago

ellensp commented 3 years ago

The Example configuration file MKS-Robin-E3-E3D/firmware/marlin2.0 for Ender3/Marlin/Configuration.h has #define SERIAL_PORT_2 -1

This is Incorrect

-1 can only be used when the USB D+ and D- lines are directly connected to the Controllers MPU pins.

This board uses a usb/seral converter chip.

mks-viva commented 3 years ago

Hi! Thank you for your feedback, we will test it and fix it.

ellensp commented 3 years ago

Ignoring the issue and sticking your head in the sand is not fixing it!

mks-viva commented 3 years ago

Ignoring the issue and sticking your head in the sand is not fixing it! https://github.com/makerbase-mks/MKS-Robin-E3-E3D/edit/ender3-3d-touch/firmware/marlin2.0%20for%20Ender3/Marlin/Configuration.h I has disable it

mks-viva commented 3 years ago

At that time, Test firmware can be used normally, and the device corresponding to the value of -1 is not actually considered

ellensp commented 3 years ago

With more modern marlin it knows the controller doesn't have USB CDC serial and errors to tell you not to set -1. Users where copying these older configs into modern marlin and it would fail (as it should) they then create issue that marlin was broken because you had -1 in your config so it must be correct (sigh)

All good now, thanks