makerbase-mks / MKS-Robin

MKS Robin is a powerful 32-bit 3D printer control board with STM32F103ZET6 . Support Marlin2.0. Support MKS Robin TFT24/28/32... Screens. The motherboard integrates 5 AXIS interface, hot bed, 2 heating heads, 3 NTC100K, 2 MAX31855.Support MKS Robin WIFI for cloud printing.Supports firmware update by SD card…
https://es.aliexpress.com/item/32757129463.html?spm=a219c.12010612.8148356.9.5fc165f4oDUfFM
129 stars 129 forks source link

MKS robin marlin compilation error #141

Closed github051 closed 4 years ago

github051 commented 4 years ago

Can anybody please help me out on this issue ? I have attached my config files

Error

Configuration.zip

3Dangel commented 4 years ago

Try to shorten your folders. Put your Marlin folder @ C:!root and try

On Wed, Oct 23, 2019 at 03:38 github051 notifications@github.com wrote:

Can anybody please help me out on this issue ? I have attached my config files [image: Error] https://user-images.githubusercontent.com/38275035/67379658-d812d580-f5a6-11e9-91ba-dc6a4ad47dfa.JPG

Configuration.zip https://github.com/makerbase-mks/MKS-Robin/files/3761510/Configuration.zip

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/makerbase-mks/MKS-Robin/issues/141?email_source=notifications&email_token=AFYWWXI7HD25VSWEEYFZJUDQQALQ3A5CNFSM4JD6TT72YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HTYJUDQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFYWWXO27K7NTXLQ5E76A3LQQALQ3ANCNFSM4JD6TT7Q .

github051 commented 4 years ago

Thanks for reply. After placing the marlin folder in C: root directory also same issue .

TimPut commented 4 years ago

This is an issue with python3 being stricter about distinguishing byte strings and char strings. Here's the diff from my local checkout which fixes it for me:

diff --git a/buildroot/share/PlatformIO/scripts/mks_robin_nano.py b/buildroot/share/PlatformIO/scripts/mks_robin_nano.py
index eb8bca9..8b36d23 100644
--- a/buildroot/share/PlatformIO/scripts/mks_robin_nano.py
+++ b/buildroot/share/PlatformIO/scripts/mks_robin_nano.py
@@ -21,7 +21,8 @@ def encrypt(source, target, env):
         while position < length:
             byte = firmware.read(1)
             if position >= 320 and position < 31040:
-                byte = chr(ord(byte) ^ key[position & 31])
+                byte = ord(byte) ^ key[position & 31]
+                byte = byte.to_bytes(1, byteorder='big')
             robin.write(byte)
             position += 1
     finally:
github051 commented 4 years ago

HI TimPut, Thanks for reply. After modification as per your code it's working. Once again big thanks.:)

github051 commented 4 years ago

i am able to compile the robin firmware, But after flashing the new firmware LCD screen is showing Complete even after restart. I am trying to connect via usb no communication.

Marlin fw path: https://github.com/makerbase-mks/MKS-Robin/tree/master/MKS%20Robin/firmware/Marlin2.0-MKS-Robin

3Dangel commented 4 years ago

What version of MKS-Robin do you have ? What version of LCD do you have? There is a setting to set different version of LCD

On Fri, Oct 25, 2019 at 00:25 github051 notifications@github.com wrote:

i am able to compile the robin firmware, But after flashing the new firmware LCD screen is showing Complete even after restart. I am trying to connect via usb no communication.

Marlin fw path: https://github.com/makerbase-mks/MKS-Robin/tree/master/MKS%20Robin/firmware/Marlin2.0-MKS-Robin

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/makerbase-mks/MKS-Robin/issues/141?email_source=notifications&email_token=AFYWWXJ7EVHB4GFK54R4ARTQQKGL3A5CNFSM4JD6TT72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECHKMJQ#issuecomment-546219558, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFYWWXPCOJRQJ2UPA7TSW5LQQKGL3ANCNFSM4JD6TT7Q .

github051 commented 4 years ago

Iam using Mks robin 2.4 board and Mks_robin_tft 2.0 lcd

3Dangel commented 4 years ago

please read through this post

https://github.com/MarlinFirmware/Marlin/issues/9771 cheers

On Fri, Oct 25, 2019 at 11:38 AM github051 notifications@github.com wrote:

Iam using Mks robin 2.4 board and Mks_robin_tft 2.0 lcd

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/makerbase-mks/MKS-Robin/issues/141?email_source=notifications&email_token=AFYWWXKCYQSJYH3OAOAJD3DQQMVJFA5CNFSM4JD6TT72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECJBNAY#issuecomment-546444931, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFYWWXLAC6TVSKY4KRIUZJLQQMVJFANCNFSM4JD6TT7Q .

github051 commented 4 years ago

Finaly i'm able to complie and upload the Marlin fw 2.0 in my Mks robin 2.4. Now i am testing all usefull options one by one.

Thanks to all.

daniyo27 commented 4 years ago

@github051 how did you fix this? I am having the same problem with the same board!

3Dangel commented 4 years ago

Pls download from Marlin official branch and use Atom platformio or Vscode platformio to compile.

On Mon, Jan 13, 2020 at 22:29 daniyo27 notifications@github.com wrote:

@github051 https://github.com/github051 how did you fix this? I am having the same problem with the same board!

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/makerbase-mks/MKS-Robin/issues/141?email_source=notifications&email_token=AFYWWXJJZ5FSK7LDSSBZSK3Q5VETJA5CNFSM4JD6TT72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEI3KY4I#issuecomment-574008433, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFYWWXO6DSDU25DUGJW2SH3Q5VETJANCNFSM4JD6TT7Q .

daniyo27 commented 4 years ago

Thank you so much! I was previously using Atom and was presented with multiple compiling errors. VSCode was a breeze to use and my board works now!

3Dangel commented 4 years ago

Glad to hear it is working!! Cheers

On Wed, Jan 15, 2020 at 00:56 daniyo27 notifications@github.com wrote:

Thank you so much! I was previously using Atom and was presented with multiple compiling errors. VSCode was a breeze to use and my board works now!

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/makerbase-mks/MKS-Robin/issues/141?email_source=notifications&email_token=AFYWWXPXGGU7OXBHETWN2EDQ526RBA5CNFSM4JD6TT72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEI7MSQI#issuecomment-574540097, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFYWWXPBERW54I2JUW3SZUDQ526RBANCNFSM4JD6TT7Q .