search

makerbase-mks / MKS-SGEN_L-V2

MKS SGEN_L V2.0 is powerful 32-bit 3D printer control board. The CPU is LPC1769 120MHZ, SGEN_L V2 hardware Integrated 4KB EEPROM, 5AXIS and dual Z interface, has 2 way FANs and Dc12/24V out interface, support TMC UART and SPI mode...
https://www.aliexpress.com/item/4001283346331.html?spm=a2g0o.store_home.slider_165457030.0
GNU General Public License v3.0
71 stars 28 forks source link

12864 display not showing Babystep Z when Babystep X and Y are activated #24

Closed doug-scott closed 3 years ago

doug-scott commented 3 years ago

I have enabled Babysteps for x, y, and z axis. When I use the 12864 to adjust Babystep on the Z axis it is not listed. It shows "Probe Z Offset". When X and Y Babysteps are not enabled, it shows "Babystep Z". My 12864 is defined as "REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER" in configuration.h.

DSC_0263 Configuration.zip

mks-viva commented 3 years ago

I think babystep Z is necessary, babystep X or Y is not very necessary.

doug-scott commented 3 years ago

I would imagine it was discussed at some time between developers, and they decided that there was a need for it, just not everyone. I am simply pointing out that there is a bug in there, either in the hardware that may have a max number of fields for babystep labels, and it is one short of what is supported. Or, a developer never considered the existence of babystep-x and y.

Elzariant commented 3 years ago

Actually, your Baby-step for Z is activated : "Probe Z offset" is Z-baby-step combined with M851 (means the value is stored in EEPROM for next print).

#define BABYSTEP_ZPROBE_OFFSET // Combine M851 Z and Babystepping

Note : Personnaly I agree with mks-viva about the usefulness of baby-stepping X or Y during a print.

doug-scott commented 3 years ago

I think that this issue can be closed. It was more of an understanding issue than anything else.