Modified library source, breaks compiling after a make clean

makerbase-mks / MKS-TinyBee

MKS TinyBee is a mainboard for 3d printing, based on ESP32 module

GNU General Public License v3.0

116 stars 115 forks source link

Modified library source, breaks compiling after a make clean #13

Open ellensp opened 2 years ago

ellensp commented 2 years ago

You have modified files in .pio/libdeps/mks_tinybee/ESP3DLib/src/sd_ESP32.cpp and sd_ESP32.h and web_server.cpp You added various references to sd_busy_lock

The instant you do a build clean, the source no longer compiles

If you need to modify these file you need clone the library ESP3DLib=https://github.com/luc-github/ESP3DLib/archive/master.zip Make the change and then reference your cloned repository

MKS-hosiey commented 2 years ago

Please don't clear it, the modifications we made are all in the library, and the library you downloaded cannot be compiled.

ellensp commented 2 years ago

As I said, you need to make your own fork of the library with these changes, so correct version gets downloaded and installed.