search

makerbot / ReplicatorG

An open-source gcode interpreter for driving RepRaps, Makerbots, and other similar CNC beasties
http://replicat.org
GNU General Public License v2.0
404 stars 226 forks source link

Fix for skeinforge comb crash on thin structures. #275

Open Phroon opened 12 years ago

Phroon commented 12 years ago

When skeining extremely thin structures comb.py has the potential to crash. Removing .boundary allows the code to function correctly.

Credit to Daid for finding this: http://groups.google.com/group/ultimaker/msg/576f52b1407e901a

Phroon commented 12 years ago

This should fix issue #268.

FarMcKon commented 12 years ago

I just cherry-picked this for testing. Can you link to a thingiverse object that shows this bug? That way I can test it and verify the fix.

thanks for helping make our software (and since it's open source, a lot of other folk's software) better, stronger, and more bug-free.

Phroon commented 12 years ago

Skeining http://www.thingiverse.com/thing:12249 causes the comb crash.

Cyberwizzard commented 12 years ago

+1 for getting this fixed