search

makerbot / ReplicatorG

An open-source gcode interpreter for driving RepRaps, Makerbots, and other similar CNC beasties
http://replicat.org
GNU General Public License v2.0
404 stars 226 forks source link

Force https firmware urls to http #276

Closed gaelen closed 12 years ago

gaelen commented 12 years ago

Not sure if this affected all version or just Mac, but to reproduce, put in a firmware update url starting with https (like https://dl.dropbox.com/u/88233/3G5DShield/3G-5D-firmware.xml). RepG will no longer start. The user won't be able to launch the app to change it back and the preference is hidden in the global java preference file, so removing/reinstalling the app won't fix it either. Instead, just convert it to http and throw up a log message.

There is probably a better way to handle https properly, but I haven't written java in years and this seems like a acceptable fix.

FarMcKon commented 12 years ago

I cherry-picked this and am closing it.

Thanks for the contribution! Sorry it too so long to get this into our codebase.

hack on,