search

makerdao / auction-demo-keeper

Apache License 2.0
33 stars 19 forks source link

PE-560: adds support for LP tokens #44

Closed godsflaw closed 3 years ago

godsflaw commented 3 years ago

This PR adds support for LP tokens.

godsflaw commented 3 years ago

Not done yet. I simulated an ETH-A take and the amount of gas required from estimateGas exceeded the gas block limit. Not sure if this is a bug with hardhat simulation, or if this new contract really will take that much gas. I eventually got the transaction to pass in hardhat:

https://gist.github.com/godsflaw/81ca0153070e14e80b9194ae67a6a733

However, it consumed nearly all of the gas in the block. I'm hoping this is a simulator bug, and not what we can expect from this new contract. The only thing that changed is the try/catch, which is probably just buggy in the simulator.