Handle auctions which end without covering the tab - Githubissues

makerdao / auction-demo-keeper

Apache License 2.0

32 stars 19 forks source link

Handle auctions which end without covering the tab #46

Closed EdNoepel closed 3 years ago

EdNoepel commented 3 years ago

Resolved issue removed completed auctions from the active auction list:

When auctions settled at a price which did not cover tab but the whole lot was taken, they were not being deleted from the array.
Attempting to print tab.toNumber() was causing an overflow exception which prevented deletion of a completed auction.