UniswapAdaptor was inappropriately maintaining state in a local _book variable, causing it to non-deterministically associate receiveAmount with different auctions for the same collateral. Resolved this by removing the two-step liquidity check in favor of having the promise return the value directly.
There was an issue with BigNumber divided by e27 producing a slice of 0 for auction prices less than 1 Dai. (Hopefully) resolved this by changing the calculation to scale after dividing.
Made some changes to try and support the "read-only" mode advertised in the README.
Tested on Kovan, UNI-A auctions 55-58 and ZRX-A auction 3.
Bug fixes
UniswapAdaptor
was inappropriately maintaining state in a local_book
variable, causing it to non-deterministically associatereceiveAmount
with different auctions for the same collateral. Resolved this by removing the two-step liquidity check in favor of having the promise return the value directly.BigNumber
divided by e27 producing aslice
of 0 for auction prices less than 1 Dai. (Hopefully) resolved this by changing the calculation to scale after dividing.Tested on Kovan, UNI-A auctions 55-58 and ZRX-A auction 3.