Split the data object returned by utils.js into two: grantsData and meetupsData, which respectively pull from the grants/meetups data in publicData.json
Changed imports of/references to data to grantsData in primaryStatProjectCountries.js, primaryStatProjectStatus.js, primaryStats.js, ProjectList.js, and Header.js
Motivation & Context
Issue[ #7 ]
Types of changes
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation Update
[ ] Other (please describe):
Does this introduce a breaking change?
Breaking change is defined as"A fix or feature that would cause existing functionality to change."
[ ] Yes
[x] No
Checklist:
[x] My code follows the code style of this project.
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added/changed necessary documentation (if appropriate)
[ ] All new and existing tests passed.
How Has This Been Tested?
After running npm run test with Node 12.3.1, unit tests failed on Validating project Degens...errorinvalid JSON for project: Degens: data.type should be equal to one of the allowed values,
but based on my conversations with @MaximumCrash, it seems like further work is required to re-evaluate the test suite to confirm that it's still applicable to the dashboard site, so I'm unsure if this result actually indicates a problem with my code.
The grants dashboard still displays data correctly with the reformatted publicData.json file, and no breaking changes were added, so I believe this PR is ready to be merged.
Attention (CC)
@as-dr @MaximumCrash
Summary of changes
publicData.json
filedata
object returned byutils.js
into two:grantsData
andmeetupsData
, which respectively pull from the grants/meetups data inpublicData.json
data
tograntsData
inprimaryStatProjectCountries.js
,primaryStatProjectStatus.js
,primaryStats.js
,ProjectList.js
, andHeader.js
Motivation & Context
Types of changes
Does this introduce a breaking change?
Breaking change is defined as "A fix or feature that would cause existing functionality to change."
Checklist:
How Has This Been Tested?
npm run test
with Node 12.3.1, unit tests failed onValidating project Degens...error
invalid JSON for project: Degens: data.type should be equal to one of the allowed values
, but based on my conversations with @MaximumCrash, it seems like further work is required to re-evaluate the test suite to confirm that it's still applicable to the dashboard site, so I'm unsure if this result actually indicates a problem with my code.publicData.json
file, and no breaking changes were added, so I believe this PR is ready to be merged.Screenshots (if appropriate):
Further comments