Closed 0xldr closed 1 week ago
[x] Sync Community Git
[x] Ensure you are working from the latest master branch
[x] Read Associated Executive Contents sheet
[x] Copy the executive template
[x] Update filename
[x] Update dates - exact time is not required and should be left at midnight.
[x] Ensure the title refers to the most impactful/important actions included in the proposal.
[x] Ensure that the summary refers to all actions included in the proposal.
[x] Ensure that the publisher (entity publishing the executive on the voting portal) of the executive is listed in the preamble (at the entity level).
[x] Ensure that the writers of the executive code are listed in the preamble (at the entity level).
[x] Ensure that the reviewers of the executive code are listed in the preamble (at the entity level).
[x] Ensure that the office-hours modifier is mentioned as part of the executive copy, if present in the executive spell code.
[x] Ensure that it is clearly stated which items are affected by the GSM Delay.
[x] Ensure that the GSM Delay period is clearly communicated.
[x] Ensure that the proposal expiry is explicitly noted, including the length of time for which the proposal is valid.
[x] Add each item to the proposal details section
[x] Order the items by judged impact/importance. If different from the executive contents, reorder the executive contents sheet so that they match.
[x] For each item
Just one typo corrected. The rest is good to go!
[x] Check each item is present in the proposal details section
[x] Check items are ordered by judged impact/importance
[x] For each item
cast keccak -- "$(wget https://raw.githubusercontent.com/makerdao/community/0434f8718e4b63cfeb4bcc0f87b8a34ec3c8ea36/governance/votes/Executive%20vote%20-%20November%2014%2C%202024.md -O -)"
[0] Downloading 'https://raw.githubusercontent.com/makerdao/community/0434f8718e4b63cfeb4bcc0f87b8a34ec3c8ea36/governance/votes/Executive%20vote%20-%20November%2014%2C%202024.md' ...
HTTP response 200 [https://raw.githubusercontent.com/makerdao/community/0434f8718e4b63cfeb4bcc0f87b8a34ec3c8ea36/governance/votes/Executive%20vote%20-%20November%2014%2C%202024.md]
0xfb975e3cd0a4f127e0c19c95a778d5f3d4263de733a347f5cd7e7030252cb007
0xfb975e3cd0a4f127e0c19c95a778d5f3d4263de733a347f5cd7e7030252cb007
matches the output of https://emn178.github.io/online-tools/keccak_256.html
With the new changes, we're getting a hash of:
0x1bb8e29f12f8d0a4d03a82f8b9ad78945d3de288a79895142d213ceb2a6d0820
Command:
cast keccak -- "$(wget 'https://raw.githubusercontent.com/makerdao/community/15c84e55529a280e29eeda56ec4bc0651ef42542/governance/votes/Executive%20vote%20-%20November%2014%2C%202024.md' -q -O - 2>/dev/null)"
Hash:
0x1bb8e29f12f8d0a4d03a82f8b9ad78945d3de288a79895142d213ceb2a6d0820
The hash matches with the outcome of this online tool: https://emn178.github.io/online-tools/keccak_256.html
I've made the first run through the document as well and left some suggestions. I'll check it again in a few hours. On the other hand, we might need to wait until tomorrow with final review, if Rema decides to provide the rate changes for this spell.