issues
search
makerdao
/
developerguides
Developer guides to integrate with MakerDAO's smart contracts, SDKs, APIs, products, and partners
Apache License 2.0
647
stars
229
forks
source link
Fix: how to use permit tutorial
#96
Closed
hbarcelos
closed
2 years ago
hbarcelos
commented
2 years ago
[x] Fix the
expiry
parameter not being set properly because the code didn't handle JavaScript dates properly.
The native Date object and all its methods work with timestamps with millisecond resolution.
[x] Remove the unnecessary
Promise
wrapper, because
Web3#sendAsync
method already returns a promise if the callback parameter is omitted.
expiry
parameter not being set properly because the code didn't handle JavaScript dates properly.Promise
wrapper, becauseWeb3#sendAsync
method already returns a promise if the callback parameter is omitted.