makerdao / dockerized-auction-keeper

GNU Affero General Public License v3.0
21 stars 17 forks source link

Add COMP-A, LRC-A and LINK-A support #36

Closed grandizzy closed 4 years ago

grandizzy commented 4 years ago

I'm disappointed that price models for new collaterals are still dictating gas prices, preventing the keeper from managing the transaction queue.

@EdNoepel so if we just remove \"gasPrice\": \"$(dynamic_gas)\"

from echo "{\"price\": \"${bidPrice}\", \"gasPrice\": \"$(dynamic_gas)\"}"

the keeper will take care of rest? If simple as that I can amend all files and send a PR for review

EdNoepel commented 4 years ago

I'm disappointed that price models for new collaterals are still dictating gas prices, preventing the keeper from managing the transaction queue.

@EdNoepel so if we just remove \"gasPrice\": \"$(dynamic_gas)\"

from echo "{\"price\": \"${bidPrice}\", \"gasPrice\": \"$(dynamic_gas)\"}"

the keeper will take care of rest? If simple as that I can amend all files and send a PR for review

Indeed, and env/dynamic_gas.sh can be gutted as well.