[WIP] feat: Add UNI-V2-USDC-ETH-A Collateral (SC-8095)

makerdao / dss-deploy-scripts

GNU Affero General Public License v3.0

49 stars 59 forks source link

[WIP] feat: Add UNI-V2-USDC-ETH-A Collateral (SC-8095) #106

Closed e18r closed 3 years ago

e18r commented 3 years ago

I deployed an Oracle to Kovan using the following parameters:

gem: 0x44892ab8F7aFfB7e1AdA4Fb956CCE2a2f3049619 wat: UNIV2-USDC-ETH-LP-ORACLE median USDC: 0x4c51c2584309b7BF328F89609FDd03B3b95fC677 median ETH: 0x0E30F0FC91FDbc4594b1e2E5d64E6F1f94cAB23D

The oracle's address is: 0x627969F6fe0651a703B2d0e3a5758F9fF9B7547A

Note: I haven't denyed myself yet.

brianmcmichael commented 3 years ago

The oracles team may already have a Kovan oracle which we should use if possible, since they would also update it. That said, I'm not sure if we're going to add the LP tokens to dss-deploy scripts. Might need @gbalabasquer to weigh in here.

gbalabasquer commented 3 years ago

We are gonna to add them just for kovan and mainnet deployment, so this PR should be fine. Anyway I would consider it a WIP until we have the mainnet addresses and values and we confirm the kovan ones.

gbalabasquer commented 3 years ago

Closing this PR as the mainnet version of this token was already added.