search

makerdao / dss-deploy-scripts

GNU Affero General Public License v3.0
49 stars 59 forks source link

Replace `cd`, `dapp build` and `dapp create` #34

Closed icetan closed 5 years ago

icetan commented 5 years ago

Based on discussion here: https://github.com/makerdao/testchain-dss-deployment-scripts/pull/32#discussion_r285639610

These changes will enable us to drop most of the cd garble regex patching in the Nix derivation.

I also think this is a more declarative way of writing build/create statements. You don't have to trace backwards in the script from a dapp create to figure out which lib you are currently in.

You also don't have to add the cp *.abi lines later, no more misspelling or forgetting to add them :)

icetan commented 5 years ago

This looks great to me. Are there any blockers to merging this, other than the merge conflicts?

@asymmetric not that I know of. @gbalabasquer what do you think?

gbalabasquer commented 5 years ago

LGTM. I was trying to see if there was some easy way to remove the cd at all from the direct running but didn't come to any conclusion yet, so we can move on with this PR. The only thing about the abi files is we will still need to copy manually the ones generated in the dss-deploy scripts.