search

makerdao / dss-deploy-scripts

GNU Affero General Public License v3.0
49 stars 59 forks source link

adds copyBins #68

Closed godsflaw closed 4 years ago

godsflaw commented 5 years ago

This adds bin and bin-runtime files in addition to the abi files. This is something @EdNoepel needed and something @brianmcmichael and I discussed adding when working on fixing etherscan verification.

brianmcmichael commented 5 years ago

Might not be a bad idea, if not here, then in another PR, to also export the flattened source code in case someone wants to do a manual submission to etherscan or just track it for versioning purposes.

godsflaw commented 4 years ago

@icetan Hey Christopher. When you get back, can you take a quick look at the build and give me your thoughts on why cachix is failing now? I don't think it would be related to the changes I made.

gbalabasquer commented 4 years ago

@godsflaw maybe has to do with the branch being in an external repository. But I'm just guessing... Would you like trying to create a PR with these changes but from a makerdao/dss-deploy-scripts branch?

gbalabasquer commented 4 years ago

Seems it is also passing now. Maybe something was changed in the CI. Anyway, closing this PR as it became duplicated.