search

makerdao / dss-deploy-scripts

GNU Affero General Public License v3.0
49 stars 59 forks source link

Yfi a collateral #98

Closed gbalabasquer closed 3 years ago

kmbarry1 commented 3 years ago

Was there some rush here? Surprised to see this merged w/o review.

gbalabasquer commented 3 years ago

This time this work was done by Sam and I've reviewed it (also tested on testchain and YFI was getting deployed without any problem). Just didn't mark it in the PR. It's true that I added the request to the team but it was more as an habit than an actual need (the change is quite minor and in the past used only pass by me). But yeah I could have ping someone else to take it a look.

Regarding the rush, YFI was included in the last spell so I figured having the scrips updated for whoever needs it for testing would be better.