search

makerdao / dss-deploy

Set of smart contracts and bash scripts to deploy Multi collateral DAI
GNU Affero General Public License v3.0
68 stars 39 forks source link

Does `mat` belong here or in the pit? #13

Closed levity closed 5 years ago

levity commented 5 years ago

Maybe the storage of mat can be moved to the Pit, just like spot and line?

https://github.com/makerdao/dss-deploy/blob/fe76c436349f8f6fc110553d0583d1c214fbcaf2/src/poke.sol#L20

gbalabasquer commented 5 years ago

@rainbreak what was the reasoning of having mat coming in the spot value?

rainbreak commented 5 years ago

The interpretation of the spot is "maximum dai allowed per collateral", which is the only price feed that the core cares about. The mat used to be in the core, but was moved out for simplicity and to avoid using division (which causes precision loss).

One thing I would consider is moving the spotter into dss, where it would be a component similar to the collateral adapters, defining the boundaries of the system.

gbalabasquer commented 5 years ago

Sounds good to me, after we define the latest dss changes, I could move the spotter.