search

makerdao / dss-deploy

Set of smart contracts and bash scripts to deploy Multi collateral DAI
GNU Affero General Public License v3.0
68 stars 39 forks source link

add test to ensure that all nescessary auth connections are present #3

Closed d-xo closed 6 years ago

d-xo commented 6 years ago

Adds a new test that ensures that auth connections shown in https://github.com/makerdao/dss/wiki/Auth are present.

I wasn't sure what the dotted line from dssDeploy to Mom meant in the diagram, so it's not tested for now. @rainbreak @gbalabasquer do you know?

I couldn't figure out a way to ensure that only these connections exist in a solidity unit test. Is there something I'm missing?

rainbreak commented 6 years ago

dssDeploy has rely mom for adding new collateral types via mom.

It isn't possible to check that these are the only connections in ds-test. You'd have to do it via a testnet and watching the event emitted by rely.

d-xo commented 6 years ago

@rainbreak dssDeploy doesn't have rely (it uses DSAuth instead).

Right now, it has an instance of DSRoles as it's authority and no owner. Is this correct? Should I update the diagram, or do we want to modify the permissions in dssDeploy?

https://github.com/makerdao/dss-deploy/blob/master/src/DssDeploy.sol#L277

rainbreak commented 6 years ago

No that's fine for now, with DSRoles authority.