search

makerdao / dss-deploy

Set of smart contracts and bash scripts to deploy Multi collateral DAI
GNU Affero General Public License v3.0
68 stars 39 forks source link

ISSUE-335: Explicitly declare compiler version #41

Closed godsflaw closed 5 years ago

godsflaw commented 5 years ago

This PR locks solidity to a very specific version 0.5.11 in preparation for deployment. We wanted to make sure it was at least 0.5.7 to fix bugs in ABIEncoderV2. We discussed locking to 0.5.9 for klab, and ultimately decided to lock to 0.5.11.

gbalabasquer commented 5 years ago

hey Chris, for dss-deploy and dss-deploy-scripts we need to update nix/dapp.nix file when dependencies are upgraded. It is being used for nix-shell.

To update that file, you need to make sure you have your local with the new version of the submodules upgraded and run: 

nix run -f https://github.com/icetan/dapp2nix/tarball/master -c dapp2nix nix/dapp.nix
godsflaw commented 5 years ago

hey Chris, for dss-deploy and dss-deploy-scripts we need to update nix/dapp.nix file when dependencies are upgraded. It is being used for nix-shell.

To update that file, you need to make sure you have your local with the new version of the submodules upgraded and run:

nix run -f https://github.com/icetan/dapp2nix/tarball/master -c dapp2nix nix/dapp.nix

All set, changes are in nix/dapp.nix

godsflaw commented 5 years ago

thanks @gbalabasquer