Adding MANA and updating token tests

makerdao / dss-deploy

Set of smart contracts and bash scripts to deploy Multi collateral DAI

GNU Affero General Public License v3.0

68 stars 39 forks source link

Adding MANA and updating token tests #47

Closed andy8052 closed 4 years ago

andy8052 commented 4 years ago

I added the mana token and refactored the token tests to all be in the same function

andy8052 commented 4 years ago

Sounds good. Do you think I should refactor this to be 2 PRs. With one adding MANA and the other changing the test structure? That way we can get the test change merged and leave MANA as a PR?

gbalabasquer commented 4 years ago

Brian applied the same tests change in tusd branch, so it's already in master. That is probably why we are having conflicts in this PR now. So let's fix the conflicts in this PR and when we merge using the squash option this final commit will end up being only the mana addendum.

gbalabasquer commented 4 years ago

Oops I had forgotten about this PR and early in the morning already added MANA to the tokens file. We could close it.

gbalabasquer commented 4 years ago

Closing this as it is an old PR.