search

makerdao / dss-deploy

Set of smart contracts and bash scripts to deploy Multi collateral DAI
GNU Affero General Public License v3.0
68 stars 39 forks source link

Add CalcFab #64

Closed brianmcmichael closed 3 years ago

brianmcmichael commented 3 years ago

Adds a calc factory.

This will be useful to have on chain during the collateral onboarding process.

brianmcmichael commented 3 years ago

Should also be added as CALC_FAB to the changelog once it's on-chain.

gbalabasquer commented 3 years ago

I'm wondering if we would want to make the DssDeploy contract to deploy the calcs instead of having to receive them via param. So far the existing fabs in this repo were mainly created to be used via the Deployer. This change would require a bit more of work though. So let me think how complex this change would be not only in this repo but the ones importing it and the scripts.

brianmcmichael commented 3 years ago

I'm wondering if we would want to make the DssDeploy contract to deploy the calcs instead of having to receive them via param. So far the existing fabs in this repo were mainly created to be used via the Deployer. This change would require a bit more of work though. So let me think how complex this change would be not only in this repo but the ones importing it and the scripts.

Discussed this offline. Plan is to add this now for CoB and then update deployment scripts later to use the calc-fab.