search

makerdao / dss-exec-lib

DSS Executive Spellcrafting Library Contracts
GNU Affero General Public License v3.0
36 stars 21 forks source link

DssExec Factory? #30

Closed gbalabasquer closed 3 years ago

gbalabasquer commented 4 years ago

Wondering if we should have a DssExecFactory for passing the SpellAction instead of having to do a dapp create DssExec which might introduce some involuntary changes to the contract. So basically removing from the equation that DssExec can be wrongly deployed due some contract alteration.

This factory would be removed when the new DssGov is implemented, as it will accept actions directly. So I see it like a nice transition, users will create SpellActions which for now will be passed to DssExecFactory, which will return the spell to be added to the DSChief. In the future that middle step will be just removed.

gbalabasquer commented 4 years ago

If we do not want a factory, then I'd suggest to keep the same way than today where the action is being deployed via the Spell, IMO it feels there is more control of what is being deployed.

brianmcmichael commented 4 years ago

I think this makes sense. We'd still have to do a dapp create DssAction, but maybe that's simpler to write.

brianmcmichael commented 4 years ago

Ready for review https://github.com/makerdao/dss-exec-lib/pull/33