search

makerdao / dss-gov

GNU Affero General Public License v3.0
4 stars 6 forks source link

Active/Inactive delegated address instead of owner #10

Closed gbalabasquer closed 4 years ago

gbalabasquer commented 4 years ago

@kmbarry1 @godsflaw @derek-flossman @jparklev Active is now based on delegated address and with just one tx the delegated address can enable back all the voting power. delegate(address(0)) for now just means setting delegation to nobody, we can discuss later if we want to change that.

New diagram of examples for this version: https://docs.google.com/drawings/d/1pPtUbISBgx7iB3-UO7Qz56K-xvFlmW_A1_Qs7V63PAM/edit

gbalabasquer commented 4 years ago

Great, thanks for the review. We need to discuss about revoking the delegation as yes there are some caveats about leaving it there forever. Let's do that in another PR.

gbalabasquer commented 4 years ago

Nice one. Does this mean you have to delegate to yourself to get the voting rights for your own MKR?

Yes, at least for now. That is the most modular way to do it and treat every address the same. We can discuss if worth it to add shortcuts in expense of more logic in some functions.