search

makerdao / dss-interfaces

Abstract developer interfaces to the Dai Stablecoin System core contracts.
GNU Affero General Public License v3.0
33 stars 26 forks source link

Adds a ds-rune abstract #18

Closed brianmcmichael closed 4 years ago

brianmcmichael commented 4 years ago

Adds an abstract for a ds-rune contract, which is an enhanced spell interface for interacting with the MCD GSM

brianmcmichael commented 4 years ago

A couple of open concerns/questions:

1) sig is the abi.encodeWithSignature() value, fax is the abi.encodeWithSelector() (bytes4) value. sig will be more versatile but adding it here will require it for cases when only fax() is necessary.

2) action is used in ds-launch spells, but generally returns the contract address of a contract to be executed (which will not apply in all cases). In other cases we have defined a usr() address, which appears to refer to a contract to be acted upon. We should figure out if we want to require this field and what it should represent.