search

makerdao / dss-interfaces

Abstract developer interfaces to the Dai Stablecoin System core contracts.
GNU Affero General Public License v3.0
33 stars 26 forks source link

add MkrAuthorityAbstract #26

Closed kmbarry1 closed 4 years ago

brianmcmichael commented 4 years ago

Looks good.

Would it be worthwhile to also add burn(), burnFrom(), and mint() (all return bytes4) here?

kmbarry1 commented 4 years ago

Eh, unsure. They're constants, so that makes them rather uninteresting. Plus in a test it's better to put the explicit value you expect, rather than using what value the contract thinks it should. Arguably they shouldn't have been public.

Anyway, that's the melange of reasons floating in my head for why I didn't do it in the first place. But if this repo is supposed to just exactly match the entire public interface of each contract it catalogs, then sure, why not.